-
Notifications
You must be signed in to change notification settings - Fork 112
feat(pci-instances): add network block for instance creation #20562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tsiorifamonjena
merged 1 commit into
feat/add-instance-creation-page-TAPC-4445
from
feat/pci-instances-add-network-bloc
Dec 4, 2025
Merged
feat(pci-instances): add network block for instance creation #20562
Tsiorifamonjena
merged 1 commit into
feat/add-instance-creation-page-TAPC-4445
from
feat/pci-instances-add-network-bloc
Dec 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59331c3 to
32e521d
Compare
...apps/pci-instances/src/pages/instances/create/components/network/NetworkHelper.component.tsx
Show resolved
Hide resolved
32e521d to
23b0131
Compare
23b0131 to
146f6be
Compare
146f6be to
866a5b7
Compare
aTurmo
approved these changes
Dec 3, 2025
| </ShellContext.Provider> | ||
| ); | ||
|
|
||
| export const renderWithMockedWrappers = ( |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
lolottetheclash
approved these changes
Dec 4, 2025
| }; | ||
| }); | ||
|
|
||
| describe('Considering NetworkHepler component', () => { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here ^^
fredericvilcot
approved these changes
Dec 4, 2025
ref: #TAPC-5315, #TAPC-5316, #TAPC-5318 Signed-off-by: tsiorifamonjena <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
866a5b7 to
5234d70
Compare
df2049c
into
feat/add-instance-creation-page-TAPC-4445
11 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #TAPC-5315, #TAPC-5316, #TAPC-5318
Additional Information